Skip to content

Authorizer stub not implementing all Authorizer contract methods causing an error #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2022
Merged

Authorizer stub not implementing all Authorizer contract methods causing an error #180

merged 1 commit into from
Apr 10, 2022

Conversation

helmroos
Copy link
Contributor

@helmroos helmroos commented Apr 5, 2022

Generating a new authorizer (like php artisan jsonapi:authorizer blog --server=v1) will have the application crash with an error as the showRelated method was not included out-of-the-box:

Class App\JsonApi\Authorizers\BlogAuthorizer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (LaravelJsonApi\Contracts\Auth\Authorizer::showRelated)

lindyhopchris
lindyhopchris approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@lindyhopchris lindyhopchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing the PR!

@lindyhopchris lindyhopchris merged commit 5961d73 into laravel-json-api:develop Apr 10, 2022
@helmroos helmroos deleted the authorizer-stub branch April 28, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindyhopchris lindyhopchris lindyhopchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helmroos @lindyhopchris