-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gammu notification #18
Add Gammu notification #18
Conversation
Revisions
Applied fixes from StyleCI
# Conflicts: # README.md
Hello @matriphe, looks like @kristiandrucker is working on a Gammu channel as well, can you please see if you can work together on a single package? |
@themsaid sure. I'd love to. I have looked at @kristiandrucker's gammuApi and it is a complete application. mine were made by following the skeleton of this project. not sure how to start if me and @kristiandrucker will work on the same project. any idea? |
Hi you could make the api have multiphone support? And also have a default phone that a user may use. That way your app will be in my api and there will only be a notifications wrapper for that api. |
@kristiandrucker I have experience with multiphone. it's basically an entry in To use multiple phone, just use public function toGammu($notifiable)
{
return (new GammuMessage())
->to($toPhoneNumber)
->sender($phoneId)
->content($message);
} |
@kristiandrucker the default phone sender can be set in the config, inside the |
one more thing, I will add the will work on that. |
So shall we start a new channel with the code in this PR? |
oh, I could add method to send via API to your app by providing key just like yours, if we want to avoid inserting directly to database. in my assumption, it's used on the same server (or different server) where the Gammu installed. I found Kalkun API can be used, but I think it need to be in separated channel. |
@themsaid I think so. but let's wait @kristiandrucker response for this. |
Hi sorry I was helping out my friend setting up his server. My gammu api already has queueing features. |
Oh, I see. @kristiandrucker's GammuAPI is a Gammu service/application so, if someone want to send SMS using Gammu, they should install GammuAPI and talk via API. I created a notification package that send SMS by inserting data directly to Gammu (the default Gammu way), assuming the application is using Gammu natively. I think we should have a same view here. It used different approach. I prefer using Gammu natively, since I used traditional Gammu way. If someone want to use it, they don't need to install other application, just use native Gammu way. But if we want to use a Gammu API, I think we can make another notification channel that use @kristiandrucker's Gammu APIs. So, @themsaid what's your opinion about it? Should we use the native way, or we use API and make separate channel? |
Btw how are you planning to use gammu on a prod server? It would be harder to setup that configuration and its better to have an api directly on the gammu server that talks to gammu and then anyone with access key can use it. |
I use separate Gammu server, with separate database. In my app, we can add the config in the config file to point to this database server. The Gammu can be isolated from public network. If you read the readme, there's a config setup that must be set, assuming the Gammu is running and working. Based on my experience, the problem is taking Gammu up, running, and working with the modem. Once it's run, it's easy to send SMS by inserting to |
@themsaid Whats your opinion on this? |
@matriphe Or we could make the Gammu api that can use mysql db or directly interact with gammu. So the users can choose what to use. |
@kristiandrucker probably by separating the channel? |
@kristiandrucker if we want to make one channel, we can provide some "switch" in config file, so user can select, probably like this in config // gammu.php
return [
'method' => 'api', // selection: api or native
'api_url' => '', // URL to GammuAPI if use API
'database' => [ // if use native/database
'host' => '',
'user' => '',
'password' => '',
'database' => '',
]
]; what do you think? |
@kristiandrucker btw, does your GammuAPI support sending a long SMS text (message is more than 160 characters)? if does, we can directly pass the long message to the API without manually chopping message into chunks before sending it |
@matriphe it should but they will be chunked down into 160 char messages by gammu or only sliced down to 160 chars. Haven't tested it. |
We could do that. |
@kristiandrucker yes, in my experience, for Long SMS can be done by splitting it to chunks and then insert the first chunk to |
I'm not familiar with Gammu :) |
Ok. Its up to you. Also Im planning to improve on my api. |
@themsaid I'm willing to work with @kristiandrucker for this channel |
@themsaid When are you ready to start? |
Will install the repo today and add both of you as Admins :) |
@themsaid thanks |
Repo created and both of you were added as admins :) |
No description provided.