feat: add robust MCP file configuration writer #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds FileWriter class that 'intelligently' handles plain JSON files, and JSON5 style files which VS Code supports. - Detects & preserves JSON 5 features (comments, trailing commas) - 'Smart' injects based on existing keys and indents
pushpak1300
reviewed
Aug 27, 2025
pushpak1300
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FileWriter class that 'intelligently' handles plain JSON files, and JSON5 style files which VS Code supports.
Fixes #107
--
We keep the basic
json_decode -> data_set -> json_encode -> writeprocess for 'plain' JSON files, and only fallback to complex injection when we detect a JSON5 style file. This allows people to keep their comments inmcp.jsonand we won't overwrite them, they'll stay retained, and we'll inject our config at the exact right place.