Add Filament guidelines #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why
This adds Filament core guidelines, and v4 guidelines. I paired with Dan Harrin on some of these, and there wasn't anything material we could add to v3 guidelines, so I've left them even though it feels wrong.
Filament's backwards compatibility & such is just so good that the core guidelines cover v3 too so far!
Working on these also highlighted an improvement we could make to calling artisan commands with interactive elements.
How I tested
Notes/thoughts