Skip to content

Conversation

alexeymezenin
Copy link
Contributor

It should be ->cron('* * * * *') instead of ->cron('* * * * * *') I guess

It should be ->cron('* * * * *') instead of ->cron('* * * * * *')
@GrahamCampbell
Copy link
Member

No?

@dciancu
Copy link
Contributor

dciancu commented Feb 25, 2016

It should be ->cron('* * * * ') instead of ->cron(' * * * * *') I guess

The PR is correct, but the comment isn't.

There are 5 stars in cron: minute, hour, day of the month, month, day of the week.

@alexeymezenin
Copy link
Contributor Author

Sorry, there is a mistake in the comment (I forgot to use code tags, so result was broken). The problem is there are six asterisks in documentation, but it should be five.

@GrahamCampbell
Copy link
Member

See #1950.

@dciancu
Copy link
Contributor

dciancu commented Feb 25, 2016

@GrahamCampbell You are correct.

Looking at https://github.com/laravel/framework/blob/5.2/src/Illuminate/Console/Scheduling/Event.php clearly reflects that it has been implemented with 6 arguments, maybe the first one is for seconds?

I find it very confusing because the Linux cron is implemented with 5 arguments. I'll discuss it on Slack.

@taylorotwell
Copy link
Member

There is an optional 6th "year" argument available: http://www.nncron.ru/help/EN/working/cron-format.htm

@dciancu
Copy link
Contributor

dciancu commented Feb 25, 2016

@taylorotwell thanks for the pointer.

@alexeymezenin
Copy link
Contributor Author

Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants