Skip to content

Conversation

kmark
Copy link

@kmark kmark commented Apr 13, 2016

See laravel/framework#13138.

I'm not confident on the wording or placement here. I imagine we'd have to summarize the argument put forth in the above issue in just a sentence or two. Is "using Laravel's validation" descriptive enough or too broad?

One alternative I've considered:

Note: When using Laravel's validation, do not use $request->get('name') in place of $request->input('name') as the former may potentially return a different value than the one Laravel has validated against.

@taylorotwell
Copy link
Member

$request->get() is never mentioned in the documentation though? I'm not sure why anyone would try to call it?

@kmark
Copy link
Author

kmark commented Apr 13, 2016

Hi Taylor, thanks for taking a look. It's a publicly exposed/available method so it will show in, as an example, PhpStorm method listings and appear to work as one might expect given its name. It seems here that the Symfony and Laravel methods conflict rather than compliment each other. I do agree that bringing up this method out of nowhere in the documentation specifically for this warning could be odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants