Stop recommending and/or over &&/||
#290
Conversation
The coding guidelines suggest using `and` and `or` over `&&`
and `||`. Frankly I don't think this is a good idea. The
precedence rules for `and` and `or` are so weird, they will
cause lots of confusion and edge cases.
To illustrate this, look at the following example ([from logical
operators][0]):
$x = false or true;
What do you expect the value of `$x` to be? It's `false`, because
`or` has lower precedence than `=`. So while you expected the
expression to be:
$x = (false or true);
It is in fact:
($x = false) or true;
Stop using `and`/`or` as logical operators. They were designed
for flow control.
[0]: http://php.net/manual/en/language.operators.logical.php
Stop recommending `and`/`or` over `&&`/`||`
|
I always use 'and' / 'or' as they improve readability. But I wrap in parenthesis things to make sure they play along nicely just like && / ||. This is a source for really freak bugs to someone who does not know they have a VERY different order or precedence compared to their non literal variants. |
|
Using |
|
Yeah I agree it's an easy mistake. It's bitten me once, but thankfully a unit test caught it. In general, I prefer the "look" of just |
The coding guidelines suggest using
andandorover&&and
||. Frankly I don't think this is a good idea. Theprecedence rules for
andandorare so weird, they willcause lots of confusion and edge cases.
To illustrate this, look at the following example (from logical
operators):
What do you expect the value of
$xto be? It'sfalse, becauseorhas lower precedence than=. So while you expected theexpression to be:
It is in fact:
Stop using
and/oras logical operators. They were designedfor flow control.