Add note about 7.2.0 compat #3889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenluijten
reviewed
Nov 30, 2017
installation.md
Outdated
| - OpenSSL PHP Extension | ||
| - PDO PHP Extension | ||
| - Mbstring PHP Extension | ||
| - Tokenizer PHP Extension | ||
| </div> | ||
|
|
||
| > **Note** recent changes to PHP (version 7.2.0 and above) can, in some situations, cause errors and warnings. If you want to use PHP 7.2.0 and above, consider using a newer version of PHP. |
There was a problem hiding this comment.
If you want to use PHP 7.2.0 and above, consider using a newer version of PHP.
Huh?
|
Let's fix the problem instead of saying we don't support 7.2. |
|
@taylorotwell - ping for FYI relevant long discussions here about the 7.2 incompability issues for Laravel 5.1 that were discussed previously; laravel/framework#20258 Not sure how we can approach the fix though. |
|
Is the take away here that PRs fixing 5.1 to work with 7.2 would be accepted? If so I'm more than happy to open a few PRs to get things working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed laravel/framework#22162 (comment)