Skip to content

Update upgrade.md for Foreign keys in SQLite #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

okdewit
Copy link
Contributor

@okdewit okdewit commented Sep 6, 2018

See laravel/framework#25475.

I think this (currently undocumented) breaking change is a good decision overall.

But I also think it would be a good addition to explicitly mention in the upgrade guide for 5.7, as the impact can be quite significant and unexpected.

One scenario where this heavily affects the upgrade process is when you use:

  • MySQL as your main database
  • in-memory SQLite as your testing database
  • have functional tests using the refreshDatabase trait,
  • and have migrations which drop foreign keys.

@taylorotwell taylorotwell merged commit d03d0b4 into laravel:5.7 Sep 6, 2018
@okdewit okdewit deleted the patch-1 branch September 7, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants