[8.x] Clarify defining recipients when using Mailables in mail notifications #6816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a very very deep dive into the behavior of defining recipients when using Mailables instead of MailMessages in mail notifications and came to the following conclusion: when using Mailables the recipients are always defined explicitly by using the
->tomethod on the mailable based on the notifiable.This means that in the case for regular notifiable models the
routeNotificationForMailmethod (or default of->emailfor that matter) and for the case of on-demand notifications the recipient defined by the notifiable needs to be explicitly passed to the mailable.I was genuinely confused myself at first after reviewing the following issue: laravel/framework#36115. I believe adding this extra part to the docs here can clarify a lot for our users.