Skip to content

Conversation

rennokki
Copy link

@rennokki rennokki commented Jun 2, 2022

@rennokki rennokki marked this pull request as draft June 2, 2022 16:11
@rennokki rennokki marked this pull request as ready for review June 2, 2022 19:06
rennokki and others added 5 commits June 3, 2022 23:17
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
@rennokki rennokki marked this pull request as draft June 4, 2022 15:04
@rennokki rennokki marked this pull request as ready for review June 7, 2022 20:31
@rennokki
Copy link
Author

@taylorotwell

@taylorotwell
Copy link
Member

I don't see any such method channelAuthorizationRoutes in the framework?

@rennokki
Copy link
Author

@taylorotwell Missed that by accident.

@taylorotwell
Copy link
Member

We probably need to be more specific about where exactly to call Echo.signin()

@taylorotwell taylorotwell marked this pull request as draft July 22, 2022 15:16
@driesvints
Copy link
Member

@rennokki did you have time for this yet?

@rennokki
Copy link
Author

rennokki commented Aug 1, 2022

@taylorotwell Fixed that.

@rennokki rennokki marked this pull request as ready for review August 1, 2022 18:38
@taylorotwell
Copy link
Member

Honestly I'm going to table this documentation for now. It's not a super in-demand feature of Echo. I may revisit this to give it proper documentation in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants