Skip to content
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

Fix error handling when compiling CSS and JS #526

Merged
merged 1 commit into from
May 30, 2016

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented May 29, 2016

I cloned the master branch because I wanted to start playing with the Webpack integration and discovered that the error handling was broken. So, here's a fix. :)

Aside 1: CSS minification appears to also be broken but I haven't figured that one out yet. See #527
Aside 2: Compiling requires babel-preset-es2015 but it's not in the devDependencies. Intentional?

@JeffreyWay JeffreyWay merged commit b5d0e1e into laravel:master May 30, 2016
@JeffreyWay
Copy link
Contributor

Thanks!

We're using Buble for compilation, so that Babel preset won't be needed.

@thecrypticace
Copy link
Contributor Author

thecrypticace commented May 30, 2016

Glad to help.

The compile script in package.json still uses babel which is why I asked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants