This repository was archived by the owner on Mar 31, 2020. It is now read-only.
Fix for double gulp watching tasks #692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug whereby watching tasks of the same name with the same watching directory means they will be fired exponentially!
This is because during
gulp watch
when a matching watcher file pattern triggers its task, then each task will then proceed to run all tasks with the same name.By indicating that a particular task is currently being "watched" and flagging whether elixir is in "watch mode" or not, this PR attempts to only fire the task being watched (and not all with the same name) when elixir is in watch mode.
Steps to reproduce the bug:
resources/assets/sass/a.scss
andresources/assets/sass/b.scss
both with the contents:gulp watch
resources/assets/sass/app.scss
a.scss
andb.scss
twice! 🐛Steps to check this fixes it