RedisQueue::pop() will never pop delayed jobs when expire is null

[halaei]

I guess it is a wrong behavior:

public function pop($queue = null)
{
    ...
    if (! is_null($this->expire)) {
        $this->migrateAllExpiredJobs($queue);
    }
    ...
}

And this is the correct one:

public function pop($queue = null)
{
    ...
    $this->migrateExpiredJobs($queue.':delayed', $queue);        
    if (! is_null($this->expire)) {
        $this->migrateExpiredJobs($queue.':reserved', $queue);
    }
    ...
}

Could you please double check?

[taylorotwell]

You can double check via a test.

[halaei]

Having the following configuration for Redis queue, no delayed job will ever get extracted from the delayed queue:

        'redis' => [
            'driver'     => 'redis',
            'connection' => 'default',
            'queue'      => 'default',
            'expire'     => null,
        ],