Paginate method doesn't work if key contains array notation

[eithed]

• Laravel Version: 5.4
• PHP Version: 7.1

Description:

If pagination key is of array notation (ie. page[published], page[unpublished]) when on ?page[published]=5 the value is not taken into consideration (it still displays first page)

Steps To Reproduce:

1. Paginate given dataset using paginate(10, ['*'], 'page[published]')
2. Display given dataset on view using links()
3. Go to one of the urls generated by the pagination

[rgehan]

I'm quite sure it wasn't designed with array notation in mind. Have a look at the page resolver code:

framework/src/Illuminate/Pagination/PaginationServiceProvider.php

Lines 40 to 48 in 78b3fe6

	Paginator::currentPageResolver(function ($pageName = 'page') {
	$page = $this->app['request']->input($pageName);
	if (filter_var($page, FILTER_VALIDATE_INT) !== false && (int) $page >= 1) {
	return $page;
	}
	return 1;
	});

It will look for a parameter called page[published] in the request, but the parameter has been parsed into an array, and only the page parameter exists.

In your case, the input is ['page' => ['published' => 123]] while you'd need ['page[published]' => 123] for it to work.

The issue is fixable, and I'd be happy for it to be my first contribution, but I'm not sure it is really necessary.

[eithed]

The key can be as page-published and page-unpublished so while yes, there're workarounds for it, it lacks certain... elegance (and array notation is useful altogether, while indeed not being necessary). Either way, a note in the documentation would suffice that such notation is not supported.

[rgehan]

I've fiddled with the page resolver and added support for array-noted page names.

https://github.com/rgehan/framework/blob/8b32d8e7842a9a8eff45214a0e8fafabc4d65557/src/Illuminate/Pagination/PaginationServiceProvider.php#L41-L47

I'd very much like to test this method, since it is now a bit more complicated, but I have absolutely no clue where to start.

[n7olkachev]

input method on request accepts dot notation, so it should work with page.published

[rgehan]

My PR was closed by Taylor; as I suspected, there are no plans to support this kind of notation

[n7olkachev]

Dot notation is standard in Laravel for a long time, so there is just no need for other notations.

[eithed]

Dot notation doesn't work.

I have it working with notation page-published, page-unpublished but that becomes cumbersome, when trying to check if any pagination is applied, as instead of simply doing !empty($request->input('page')) I've to check for non-emptiness of every pagination.

[lindyhopchris]

You can override the page resolver using AbstractPaginator::currentPageResolver(), then add in support yourself. That would at least means you can support it in your own application even if it is not to be supported in the framework.

[n7olkachev]

In which case dot notation doesn't work? As I understand, it should work for page resolving.
For rendering, you can use setPageName with array notation before using links method.

[eithed]

->paginate(10, ['*'], 'page.published') produces ?page.published=2 links. Going to given link doesn't advance the pagination. After proceeding to given page, hovering on the link gives me ?page_published=2&page.published=2. I guess there's some escaping going on.

[n7olkachev]

Try ->setPageName('page[published]') after ->paginate()

[eithed]

I'm confused - I thought that third parameter in paginate method did just that.

Either way, even with setPageName - nope, the pagination doesn't advance. After proceeding to the page, and hovering on the link it gives me: ?page%5Bpublished%5D=2&page%5Bpublished%5D=2

[n7olkachev]

Yep, you use dot notation in paginate for correct page resolving. After that, you use setPageName for generating correct link.
page%5Bpublished%5D=2 will work, don't be afraid of `%5B'.

[rgehan]

There seems to be escaping yes, someone bumped into the same issue with cookies.

It seems like replacing dots by underscore in incoming variables is standard PHP behavior.

The issue in question: #16167