Resolving env service before binding if class not found in configuration files.

[oanhnn]

• Laravel Version: 8.67.0
• PHP Version: 8.0.11

Description:

Resolving env service before binding if class not found in configuration files.

Steps To Reproduce:

In one config file (Eg. config/logging.php ), using a class, that isn't existed.

<?php

use Monolog\Handler\NullHandler;
use Monolog\Handler\StreamHandler;
use Monolog\Handler\SyslogUdpHandler;

return [

    /*
    |--------------------------------------------------------------------------
    | Default Log Channel
    |--------------------------------------------------------------------------
    |
    | This option defines the default log channel that gets used when writing
    | messages to the logs. The name specified in this option should match
    | one of the channels defined in the "channels" configuration array.
    |
    */

    'default' => env('LOG_CHANNEL', ClassNotExisted::CONST_A),

Run: php artisan

Expected

Throw class ClassNotExisted not found exception

Actual

Throw ReflectionException and BindingResolutionException

Uncaught ReflectionException: Class "env" does not exist in project/vendor/laravel/framework/src/Illuminate/Container/Container.php:877

Next Illuminate\Contracts\Container\BindingResolutionException: Target class [env] does not exist. in project/vendor/laravel/framework/src/Illuminate/Container/Container.php:879

Reason

Try resolving env service before binding
https://github.com/laravel/framework/blob/8.x/src/Illuminate/Log/LogManager.php#L523..L525

[driesvints]

This is how PHP works. Don't reference classes that don't exists through their namespace. Use a string instead of you need to do that.

[oanhnn]

@driesvints It is not how PHP works. Any exception has been thrown on a config file to same error.

• When PHP try load class. But this class is not existed, so that PHP throws ClassNotFoundException.
• Laravel handle this exception and try write to log.
• When Laravel get log driver, it call to runningUnitTests() to check this process is running unit test and this method resolving env service before binding.
• Ensue Laravel throw ReflectionException and BindingResolutionException like my report. It makes it difficult for developers to debug.

When i comment https://github.com/laravel/framework/blob/8.x/src/Illuminate/Log/LogManager.php#L523..L525
, it work like expected.

[driesvints]

@oanhnn I don't see an issue here sorry. Don't use classes that don't exist. If you think there's a bug here we're welcoming PR's.

[jstephancc]

Hi, it's an issue in laravel itself? I have this issue while running any artisan commands.

I'm facing the same with latest PHP 8.0.12:

MacBook-Pro-Jakub:my-project jakubstephan$ php --version
PHP 8.0.12 (cli) (built: Oct 21 2021 14:38:26) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.12, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.12, Copyright (c), by Zend Technologies

My logs:

Next Illuminate\Contracts\Container\BindingResolutionException: Target class [env] does not exist. in /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php:879
Stack trace:
#0 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php(758): Illuminate\Container\Container->build('env')
#1 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(841): Illuminate\Container\Container->resolve('env', Array, true)
#2 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php(694): Illuminate\Foundation\Application->resolve('env', Array)
#3 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(826): Illuminate\Container\Container->make('env', Array)
#4 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php(1423): Illuminate\Foundation\Application->make('env')
#5 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(631): Illuminate\Container\Container->offsetGet('env')
#6 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(523): Illuminate\Foundation\Application->runningUnitTests()
#7 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(109): Illuminate\Log\LogManager->parseDriver(NULL)
#8 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(581): Illuminate\Log\LogManager->driver()
#9 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(252): Illuminate\Log\LogManager->error('syntax error, u...', Array)
#10 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(366): Illuminate\Foundation\Exceptions\Handler->report(Object(ParseError))
#11 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(131): Illuminate\Foundation\Console\Kernel->reportException(Object(ParseError))
#12 /Users/jakubstephan/Projects/Private/my-project/artisan(37): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#13 {main}
  thrown in /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 879

Fatal error: Uncaught ReflectionException: Class "env" does not exist in /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php:877
Stack trace:
#0 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php(877): ReflectionClass->__construct('env')
#1 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php(758): Illuminate\Container\Container->build('env')
#2 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(841): Illuminate\Container\Container->resolve('env', Array, true)
#3 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php(694): Illuminate\Foundation\Application->resolve('env', Array)
#4 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(826): Illuminate\Container\Container->make('env', Array)
#5 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Container/Container.php(1423): Illuminate\Foundation\Application->make('env')
#6 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(631): Illuminate\Container\Container->offsetGet('env')
#7 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(523): Illuminate\Foundation\Application->runningUnitTests()
#8 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(109): Illuminate\Log\LogManager->parseDriver(NULL)
#9 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(581): Illuminate\Log\LogManager->driver()
#10 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(252): Illuminate\Log\LogManager->error('syntax error, u...', Array)
#11 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(366): Illuminate\Foundation\Exceptions\Handler->report(Object(ParseError))
#12 /Users/jakubstephan/Projects/Private/my-project/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(131): Illuminate\Foundation\Console\Kernel->reportException(Object(ParseError))
#13 /Users/jakubstephan/Projects/Private/my-project/artisan(37): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#14 {main}

Composer update:

MacBook-Pro-Jakub:my-project jakubstephan$ composer update
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating optimized autoload files
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class
105 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

[driesvints]

@jstephancc post a way for me to reproduce this please.

[oanhnn]

@jstephancc
Your code maybe throw an exception in config files.
Laravel have issue when try handler this exception (logging it).
It shows error as your report instead of show this exception.
You can find this exception by commend https://github.com/laravel/framework/blob/8.x/src/Illuminate/Log/LogManager.php#L523..L525 in vendor

[oanhnn]

@driesvints

You can try

reproduce

composer create-project laravel/laravel project-test
cd project-test
php artisan
sed -i -e "s#<?php#<?php throw new \\\Exception('test');#" config/database.php
php artisan

Actual

Error like @jstephancc and me reported

Next Illuminate\Contracts\Container\BindingResolutionException: Target class [env] does not exist. in /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php:879
Stack trace:
#0 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php(758): Illuminate\Container\Container->build('env')
#1 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(841): Illuminate\Container\Container->resolve('env', Array, true)
#2 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php(694): Illuminate\Foundation\Application->resolve('env', Array)
#3 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(826): Illuminate\Container\Container->make('env', Array)
#4 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php(1423): Illuminate\Foundation\Application->make('env')
#5 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(631): Illuminate\Container\Container->offsetGet('env')
#6 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(523): Illuminate\Foundation\Application->runningUnitTests()
#7 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(109): Illuminate\Log\LogManager->parseDriver(NULL)
#8 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(581): Illuminate\Log\LogManager->driver()
#9 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(252): Illuminate\Log\LogManager->error('syntax error, u...', Array)
#10 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(366): Illuminate\Foundation\Exceptions\Handler->report(Object(ParseError))
#11 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(131): Illuminate\Foundation\Console\Kernel->reportException(Object(ParseError))
#12 /path/to/project-test/artisan(37): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#13 {main}
  thrown in /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 879

Fatal error: Uncaught ReflectionException: Class "env" does not exist in /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php:877
Stack trace:
#0 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php(877): ReflectionClass->__construct('env')
#1 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php(758): Illuminate\Container\Container->build('env')
#2 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(841): Illuminate\Container\Container->resolve('env', Array, true)
#3 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php(694): Illuminate\Foundation\Application->resolve('env', Array)
#4 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(826): Illuminate\Container\Container->make('env', Array)
#5 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Container/Container.php(1423): Illuminate\Foundation\Application->make('env')
#6 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(631): Illuminate\Container\Container->offsetGet('env')
#7 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(523): Illuminate\Foundation\Application->runningUnitTests()
#8 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(109): Illuminate\Log\LogManager->parseDriver(NULL)
#9 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(581): Illuminate\Log\LogManager->driver()
#10 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(252): Illuminate\Log\LogManager->error('syntax error, u...', Array)
#11 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(366): Illuminate\Foundation\Exceptions\Handler->report(Object(ParseError))
#12 /path/to/project-test/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(131): Illuminate\Foundation\Console\Kernel->reportException(Object(ParseError))
#13 /path/to/project-test/artisan(37): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#14 {main}

Expected

Result after comment https://github.com/laravel/framework/blob/8.x/src/Illuminate/Log/LogManager.php#L523..L525

[driesvints]

@oanhnn I finally see what you're saying. Checking into this.

[driesvints]

Sent in a PR here: #39434