Interference character | (Straight line) In trans_choice function

[MohammadZarifiyan]

Laravel Version

11.29

PHP Version

8.1

Database Driver & Version

No response

Description

When I use trans_choice and use straight line symbol (|) in the parameters, it causes the sentence structure to be messed up. It seems that Laravel first places the parameters in the sentences and then selects the sentence based on the number parameter in trans_choice. While the correct way is to first select the correct sentence in terms of number, then replace the parameters.

Steps To Reproduce

home.php file:

return [
   'greeting' => '{0} Hello :name|[1,*] Hello :name, you have :count unread messages'
];

Usage:

trans_choice('home.greeting', 0, ['name' => 'Alex | Moi']);

Above code must result in Hello Alex | Moi, But it results to Hello Alex.

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[zakariaarrid]

@MohammadZarifiyan
try using HTML encoding for the pipe for quick solution
trans_choice('home.greeting', 0, ['name' => 'Alex | Moi']);

[ShowravBiswas]

You can use a custom placeholder

{!! str_replace('__PIPE__', '|', trans_choice('home.greeting', 0, ['name' => 'Alex __PIPE__ Moi'])) !!}

Above code return your desired result which is : Hello Alex | Moi

[AndrewMast]

Correct me if I’m wrong, but could this be fixed by changing $replace with [] on line 203 of Translator.php? makeReplacements() gets called at the end of the method so we shouldn’t be missing anything. I’m currently abroad on my phone so I can’t check. Is there any purpose to the current double calling of makeReplacements() since get() already calls it?

[rudiedirkx]

I don't understand Laravel issues. More than a year ago the same bug was reported: #48127 and closed. I'm happy it's fixed, but I don't get it.

@reneroth Happy days

[reneroth]

I don't understand Laravel issues.

It’s a unique approach. It does keep the issues section very slim — honestly most projects have more open issues than can be solved in a lifetime — but at the same time it means real bugs are being closed without being solved. :/

The important learning for me is that while issues get closed easily, PRs also get merged easily, so it might be worth it just putting in a PR for smaller things.