v12.29.0 breaking change causes issues with routes name order

[kajgiesbersflavour]

Laravel Version

12.29.0

PHP Version

8.2

Database Driver & Version

No response

Description

Before this update when calling route($routeName) it would return the last defined routename, now it returns the first defined routename.

Why this breaking change matters in our specific case

We use tenancy in our application and we have multiple routes with the same name. Previously when calling route($routeName) it would automatically return the tenant route when on the tenant, and the central route when not within tenant context, now it always returns the central route.

Please let me know if you require any additional information.

Steps To Reproduce

In your routes file:

        Route::get('firstLink', [Test::class, 'test'])->name('routeTest');
        Route::get('secondLink', [Test::class, 'test'])->name('routeTest');

Then on a random blade file:

Test link: {{route('routeTest')}}

On 12.28.1 and lower, this will return:
Test link: http://hackshield.local/secondLink
Now since 12.29.0 this returns:
Test link: http://hackshield.local/firstLink

[mdMandoinfo]

I have looked into RouteCollection, and I believe that since 12.29.0, there's a change: the: refreshNameLookups() method is now called (e.g. in toSymfonyRouteCollection), rebuilding nameList from allRoutes in insertion order. Because of that, it appears that the first route defined with a given name wins, instead of the last defined as used to be in 12.28.1.

---

Example code:

if ($name = $route->getName()) {
    $this->nameList[$name] = $route;
}

---

This looks like a breaking change for apps relying on the “last route name wins” behavior.
I personally think the “last one wins” behavior is more logical in practice.

Could the Laravel team confirm if this change was intended — or if it's a bug/regression? And if it was intended, will there be a fallback option or config to opt back into the old behavior of last-defined route taking precedence?

[crynobone]

This looks like a breaking change for apps relying on the “last route name wins” behavior. I personally think the “last one wins” behavior is more logical in practice.

#56920 fixed the issue where cached routes use "FIFO" while without cache use "FILO" when resolving routes. Therefore, the changes are intended.

Additionally, your above example wouldn't work when the application is cached:

  Unable to prepare route [secondLink] for serialization. Another route has a
  lready been assigned name [routeTest].

[mdMandoinfo]

#56920 fixed the issue where cached routes use "FIFO" while without cache use "FILO" when resolving routes. Therefore, the changes are intended.

Makes sense now. Got it, thanks.