queue:listen's sleep duration contributing towards timeout

[pcorey]

To reproduce, create a simple job and call artisan queue listen:

php artisan queue:listen --sleep=5 --timeout=5

If you look in your laravel.log, you'll notice that the spawned queue:work processes are all instantly timing out:

[2014-10-23 16:17:15] dev.ERROR: exception 'Symfony\Component\Process\Exception\ProcessTimedOutException' with message 'The process ""/usr/bin/php5" artisan queue:work  --queue="default" --delay=0 --memory=128 --sleep=5 --tries=0 --env=dev" exceeded the timeout of 5 seconds.' in /.../vendor/symfony/process/Symfony/Component/Process/Process.php:1209
Stack trace:
#0 /home/.../vendor/symfony/process/Symfony/Component/Process/Process.php(357): Symfony\Component\Process\Process->checkTimeout()
#1 /home/.../vendor/symfony/process/Symfony/Component/Process/Process.php(206): Symfony\Component\Process\Process->wait()
#2 /home/.../vendor/laravel/framework/src/Illuminate/Queue/Listener.php(94): Symfony\Component\Process\Process->run(Object(Closure))
...

If you change the listen's timeout to 6 seconds, the jobs will run successfully:

php artisan queue:listen --sleep=5 --timeout=6

From my perspective (and after reading the queue docs), it seems like the specified sleep duration should not contribute towards the timeout duration. The listen process should wait seconds before checking if there's a job to run. If there is a job, the job process is spawned and expires in seconds.

This is happening in Laravel 4.2.11.

[GrahamCampbell]

Is this still an issue?

[ibrasho]

This is applicable even to 5.0.

[ibrasho]

The issue is that the timeout is applied to the pooling time, so the listener sleeps for 5 seconds, and I assume this is treated as a job, thus it exceeds the timeout.

Timeout must be always larger than sleep.

[GrahamCampbell]

This needs to be fixed on 4.2.

[ibrasho]

I can't think of a proper fix currently.

Illuminate\Queue\Listener creates a Symfony\Component\Process\Process instance with the supplied $timeout.

This Process instance runs a queue:work command that is passed the $sleep value.
Since the process has a timeout of 5 seconds, and the queue:work sleeps for the same amount of time, this leads to the TimeoutException.

The only solution I can think of is to never allow $timeout to be less than or equal $sleep in the command handle method.

[pcorey]

Is setting the timeout on the Process to timeout+sleep a bad solution? Something like...

return new Process($command, $this->commandPath, null, null, $timeout + $this->sleep);

I feel like having a $timeout <= to $sleep is a valid use case. At least according to the way I would think queues would work from a black box perspective, and the way the docs read.

[onbjerg]

I feel that @pcorey is on to something. At least it seems like it's the only "solution".