[8.x] Adds Model key extraction to id on whereKey() and whereKeyNot()
#37184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this feature, but in my opinion it should support multiple keys too. $forExample->whereKey([$model1, $model2])->get(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to get the key of a Model when a Model instance is issued on
whereKey()andwhereKeyNot()methods to the Builder for relationships.Problem & Solution
If a developer issues a Model instance to
whereKey()orwhereKeyNot(), these methods will make aWHERE INclause with all the model attributes, mainly because a Model implementsArrayable.To avoid this, these methods will check first if the
$idis a Model instance, and get the key from it.