[5.3] Fire / check queue looping event before running daemon #15290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was removed on purpose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Laravel 5.3, I've noticed the queue looping event (
illuminate.queue.looping) no longer fires. It looks like the queue worker never fires the event. SeedaemonShouldRun()in 5.2 vs 5.3.This PR reverts to the 5.2 functionality. I'm not sure if this would be considered a breaking change as the deamon will stop if a listener returns
falseto theilluminate.queue.loopingevent. This is the functionality in 5.2 and users / packages may expect 5.3 to behave the same way. On the other hand, if this is considered a breaking change, perhaps we can just fire theilluminate.queue.loopingevent without it having an effect on whether or not the daemon will run.The looping event listener is presented in contracts / classes such as Illuminate\Contracts\Queue\Monitor and Illuminate\Queue\QueueManager, therefore I assume this issue of it not being fired at all should be fixed.