[5.5] Remove usages of the with() helper #17888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Laravel 5.5 requires PHP 7 the usage of `with()` becomes unnecessary.
GrahamCampbell
requested changes
Feb 11, 2017
src/Illuminate/Support/helpers.php
Outdated
| @@ -924,16 +924,3 @@ function windows_os() | |||
| return strtolower(substr(PHP_OS, 0, 3)) === 'win'; | |||
| } | |||
| } | |||
|
|
|||
| if (! function_exists('with')) { | |||
There was a problem hiding this comment.
We shouldn't delete this helper yet.
There was a problem hiding this comment.
This helper was built to support some internal needs of the core, wasn't even documented for the users. And, after all, is for the next release. Looks reasonable to me to move forward.
I'll wait for more feedbacks about this. Thanks.
|
Yeah, let's leave the helper in place. The rest looks fine. |
|
@taylorotwell As requested, done. |
GrahamCampbell
approved these changes
Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Laravel 5.5 requires PHP 7 the usage of
with()becomes unnecessary.