New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Preserve route parameters name #18604

Merged
merged 1 commit into from Mar 31, 2017

Conversation

Projects
None yet
3 participants
@themsaid
Member

themsaid commented Mar 31, 2017

As reported in: #18593

This PR ensures that the parameter keys are preserved so that if you override Illuminate\Routing\Controller@callAction in your controller the $parameters is an associative array,

public function callAction($method, $parameters)
{
    return call_user_func_array([$this, $method], $parameters);
}

This behaviour was broken in #17973, this PR should get back the original behaviour.

@taylorotwell taylorotwell merged commit 7f1d851 into laravel:5.4 Mar 31, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frankdejonge

This comment has been minimized.

Show comment
Hide comment
@frankdejonge

frankdejonge Apr 3, 2017

Contributor

Would probably be good to add the test-case from that issue too, as a guarantee for the future.

Contributor

frankdejonge commented Apr 3, 2017

Would probably be good to add the test-case from that issue too, as a guarantee for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment