Skip to content

[5.4] Preserve route parameters name - #18604

Merged
taylorotwell merged 1 commit into
laravel:5.4from
themsaid:preserveRouteParametersNames
Mar 31, 2017
Merged

taylorotwell merged 1 commit into
laravel:5.4from
themsaid:preserveRouteParametersNames

Conversation

@themsaid

Copy link
Copy Markdown
Member

As reported in: #18593

This PR ensures that the parameter keys are preserved so that if you override Illuminate\Routing\Controller@callAction in your controller the $parameters is an associative array,

public function callAction($method, $parameters)
{
    return call_user_func_array([$this, $method], $parameters);
}

This behaviour was broken in #17973, this PR should get back the original behaviour.

@taylorotwell
taylorotwell merged commit 7f1d851 into laravel:5.4 Mar 31, 2017
@frankdejonge

Copy link
Copy Markdown
Contributor

Would probably be good to add the test-case from that issue too, as a guarantee for the future.

salmanarshad321 pushed a commit to salmanarshad321/framework that referenced this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants