Dynamic changing locale - #19405
Merged
Merged
Conversation
brandon14
added a commit
to brandon14/brandonclothier.me
that referenced
this pull request
Jun 17, 2017
base.blade: Use app()->getLocale for a bugfix for this issue: laravel/framework#19405 Also check the environment and only add site verification meta if in production. footer-error.blade: If running in production use HTTPS on the image URL, otherwise don't. Also intval the year when comparing it to 2017. Format the Carbon instance, footer.blade: Only render social media widget buttons if in production mode. Also intval year before comparing and format the Carbon instance. index.blade: Bring OpenGraph title in line iwth website title. Intval the year when comparing it to 2017. Add sameAs meta for my social media pages. Add a WebSite schema. Only include the social media JavaScript if in production. about.blade: Remove extra closing p tag. resume.blade: Only use HTTPS if in production mode on profile image.
evalesoftware
pushed a commit
to evalesoftware/eVALE
that referenced
this pull request
Nov 23, 2017
lhsazevedo
pushed a commit
to lhsazevedo/laravel-realworld-example-app
that referenced
this pull request
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix a bug that shows the default locale specified in config in the HTML attribute, even if you manually change it in your application.
Steps to reproduce bug:
App::setLocale('custom');