Skip to content

[5.5] Worker: Use usleep in case when sleep time less than 1 second #22255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

[5.5] Worker: Use usleep in case when sleep time less than 1 second #22255

merged 1 commit into from
Nov 30, 2017

Conversation

disc
Copy link

@disc disc commented Nov 30, 2017 •
edited by themsaid
Loading

Just to point out PHP_INT_MAX is 2147483647 on 32-bit platform, so this change would break with $seconds > 2147 (about 36 minutes).

related #22246

@disc disc mentioned this pull request Nov 30, 2017
Merged
@taylorotwell taylorotwell merged commit 78bf1af into laravel:5.5 Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disc @taylorotwell