[5.6] Use Bootstrap 4 in the preset#22754
Conversation
|
@mbabker hey 👋 I am the author of the laravelnews/laravel-twbs4 Bootstrap 4 preset. Upgrading involves a few more steps beyond updating the package versions—the Bootstrap 4 framework is fundamentally different. For example, the app.scss file needs updated too because this change means the |
|
I was thinking about that too, but I didn't know how in-depth to go with updating the preset. So far it seems bits and pieces of the scaffolding have been updated (mostly the authentication markup stubs) but it wasn't a full migration. From the looks of it though given all of the work that have been done between the two repos I should be able to copy the |
|
This PR breaks the Bootstrap preset. See the app.scss file where it imports a file from the |
|
Updated with |
|
@themsaid can you verify if anything else needs to be done for this migration? |
With the auth scaffolding being updated to Bootstrap 4 and the
laravel/laravelrepo also using it, I'd suggest the preset should now use Bootstrap 4 also.