Skip to content

[5.6] Fix #23592 (SeeInOrder) - #23594

Merged
taylorotwell merged 6 commits into
laravel:5.6from
Jantho1990:bugfix/see-in-order
Mar 19, 2018
Merged

taylorotwell merged 6 commits into
laravel:5.6from
Jantho1990:bugfix/see-in-order

Conversation

@Jantho1990

Copy link
Copy Markdown
Contributor

This adds a SeeInOrder PHPUnit Constraint to address Issue #23592. Calling assertSeeInOrder() or assertSeeTextInOrder() should now result in PHPUnit registering that assertions were made (and thus not marking tests with only those assertions as risky). Also added a test file to make sure PHPUnit is calling the assertions.

@Jantho1990
Jantho1990 force-pushed the bugfix/see-in-order branch from 723cf73 to f62cc01 Compare March 18, 2018 06:38
@Jantho1990
Jantho1990 force-pushed the bugfix/see-in-order branch from f62cc01 to 99cb7af Compare March 18, 2018 06:39
@GrahamCampbell GrahamCampbell changed the title Fix #23592 (SeeInOrder) [5.6] Fix #23592 (SeeInOrder) Mar 18, 2018
/**
* The string we want to check the content of.
*
* @var

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing var type.

Strange that Style CI didn't cached it 🤔

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a code style bug, that's why. It's just a syntax error.

@taylorotwell
taylorotwell merged commit 533f468 into laravel:5.6 Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants