New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Align Mailable dynamic parameter case to View (camel). #24232

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
3 participants
@jrseliga
Contributor

jrseliga commented May 16, 2018

Currently dynamic with parameters on Illuminate\Mail\Mailable are snake cased, however Illuminate\View\View was updated to camel case in 5.5.

#18083: [5.5] Camel case variables that get shared with a view

Breaking change, but for consistency, Mailable would now also use camel case.

@jrseliga jrseliga changed the title from Align Mailable dynamic parameter case to View (camel). to [5.7] Align Mailable dynamic parameter case to View (camel). May 16, 2018

@taylorotwell taylorotwell merged commit f29b3cd into laravel:master May 17, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -109,7 +109,7 @@ public function testMailableBuildsViewData()
$expected = [
'first_name' => 'Taylor',

This comment has been minimized.

@Shifterovich

Shifterovich Nov 11, 2018

Why is lastName in CamelCase but first_name isn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment