Skip to content

Conversation

andreasnij
Copy link
Contributor

The remember token was cycled even though the remember functionality never was used and the token set. In the database it looked like all the users had used the functionality, which was confusing. This change stops that and only cycles the token if it is set.

The remember token was cycled even though the remember functionality
never was used and the token set. In the database it looked like
all the users had used the functionality, which was confusing.
This change stops that and only cycles the token if it is set.
@taylorotwell
Copy link
Member

I still see no actual point in changing this.

@andreasnij
Copy link
Contributor Author

The point and benefit to the Laravel users is that it makes the user database data less confusing and lets you see which users has used the "remember me" functionality. We have applications that doesn't have a "remember me" checkbox, and yet our database is full of remember tokens.

@taylorotwell taylorotwell reopened this Jan 28, 2019
@taylorotwell taylorotwell merged commit f92726f into laravel:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants