[5.8] Remove fire method
#26392
Merged
[5.8] Remove fire method
#26392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are aliases to the `dispatch()` method.
|
yup, just saw it. brb |
update to use `dispatch()` method, as dictated by the contract.
driesvints
approved these changes
Nov 5, 2018
|
|
This was referenced Jun 4, 2019
markeilander
added a commit
to markeilander/repository
that referenced
this pull request
Aug 21, 2019
This was referenced Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fire()method is an alias to thedispatch()method. The renaming of this method started way back in the 5.3 to 5.4 upgrade, and is included in the upgrade guide:https://laravel.com/docs/5.4/upgrade
This follow PR #26379.
Because this is a breaking change, this PR targets the next release.
If accepted I will make a PR to the 5.8 Upgrade Guide.