New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Use config to resolve the database value during tests. #27240

Merged
merged 1 commit into from Jan 20, 2019

Conversation

Projects
None yet
2 participants
@lucasmichot
Copy link
Contributor

lucasmichot commented Jan 20, 2019

Laravel comes with a handy "read/write" feature.
Unfortunatelly it is impossible to keep and test this feature alike during tests, when using RefreshDatabase.

In this situation, usingInMemoryDatabase method will never resolve the database key as it's embedded under either the read either the write section, and will raise an error during tests.

This PR fix this problem.

@lucasmichot lucasmichot changed the title [5.7] Use config to resolve database value during tests. [5.7] Use config to resolve the database value during tests. Jan 20, 2019

@taylorotwell taylorotwell merged commit ea352aa into laravel:5.7 Jan 20, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment