[5.8] Provide a simple debug info in compiled views (path to view) #27412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally, I wouldn't make this configurable at all - if we are going to have it I would just have it always on. Secondly, I would put the comment at the top of the file. |
|
@taylorotwell thank you for the concerns, I'll remove redundant configuration option, move the comment to the top of the file and then be back with a new pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes laravel/ideas#1480 by adding very simple debug info to compiled views namely the path to the view in order to provide a possibility of Blade debugging in PhpStorm.
Also, I'm going to submit a PR with adding a new default option to view config if this PR is accepted: bzixilu/laravel@a17462b