[5.7] Fix for EventFake not returning responses #27430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
reviewed
Feb 6, 2019
| $this->events[$name][] = func_get_args(); | ||
| } else { | ||
| $this->dispatcher->dispatch($event, $payload, $halt); | ||
| return $this->dispatcher->dispatch($event, $payload, $halt); |
There was a problem hiding this comment.
Why not an early return?
if ($this->shouldFakeEvent($name, $payload) === false) {
return $this->dispatcher->dispatch($event, $payload, $halt);
}
$this->events[$name][] = func_get_args();There was a problem hiding this comment.
I was trying to make as small a change as possible.
driesvints
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're relying on the responses returned from the dispatcher, but when using the EventFake, nothing gets returned at all. Looks like a simple
returnwas left off.Not sure how far back this PR should go. Docs say bug fixes should go back to the LTS but this class doesn't exist in 5.5.