Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix stack channel's bug #27726

Merged
merged 3 commits into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@imanghafoori1
Copy link
Contributor

imanghafoori1 commented Mar 1, 2019

This simply fixes the #27669 issue.

I found that stack channel had no tests.
I was always working with the default log level since it was assumed that the 'level' is coming as a key in the 'with' array, but it is not documented that way on the laravel.com

https://laravel.com/docs/5.7/logging#building-log-stacks

now the tests are modified to conform to laravel docs.

imanghafoori1 added some commits Feb 22, 2019

Merge pull request #21 from laravel/5.8
Fix failing Redis test

@imanghafoori1 imanghafoori1 force-pushed the imanghafoori1:fix_logger branch from 48b3a5b to 7d7bdf6 Mar 1, 2019

@imanghafoori1

This comment has been minimized.

Copy link
Contributor Author

imanghafoori1 commented Mar 1, 2019

Should I add it on the 5.7 ? or 5.8 is ok ? @driesvints

@taylorotwell taylorotwell merged commit 7d7bdf6 into laravel:5.8 Mar 1, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@imanghafoori1 imanghafoori1 deleted the imanghafoori1:fix_logger branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.