Skip to content

[5.8] Fix stack channel's bug #27726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2019
Merged

Conversation

imanghafoori1
Copy link
Contributor

This simply fixes the #27669 issue.

I found that stack channel had no tests.
I was always working with the default log level since it was assumed that the 'level' is coming as a key in the 'with' array, but it is not documented that way on the laravel.com

https://laravel.com/docs/5.7/logging#building-log-stacks

now the tests are modified to conform to laravel docs.

@imanghafoori1
Copy link
Contributor Author

Should I add it on the 5.7 ? or 5.8 is ok ? @driesvints

@taylorotwell taylorotwell merged commit 7d7bdf6 into laravel:5.8 Mar 1, 2019
@imanghafoori1 imanghafoori1 deleted the fix_logger branch March 2, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants