Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[5.8] Fix stack channel's bug #27726
Conversation
imanghafoori1
added some commits
Feb 22, 2019
imanghafoori1
force-pushed the
imanghafoori1:fix_logger
branch
from
48b3a5b
to
7d7bdf6
Mar 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Should I add it on the 5.7 ? or 5.8 is ok ? @driesvints |
taylorotwell
merged commit 7d7bdf6
into
laravel:5.8
Mar 1, 2019
imanghafoori1
deleted the
imanghafoori1:fix_logger
branch
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
imanghafoori1 commentedMar 1, 2019
This simply fixes the #27669 issue.
I found that stack channel had no tests.
I was always working with the default log level since it was assumed that the 'level' is coming as a key in the 'with' array, but it is not documented that way on the laravel.com
https://laravel.com/docs/5.7/logging#building-log-stacks
now the tests are modified to conform to laravel docs.