Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Allow to call macros directly on Date #28129

Merged

Conversation

Projects
None yet
2 participants
@kylekatarnls
Copy link
Contributor

kylekatarnls commented Apr 6, 2019

The following modification on DateFactory.php avoid the test below to throw an exception: allows macros that can be called statically and that return values that are note dates to be called directly on the Date facade.

@kylekatarnls kylekatarnls changed the title Allow to call macros directly on Date [5.8] Allow to call macros directly on Date Apr 6, 2019

@taylorotwell taylorotwell merged commit b699e5e into laravel:5.8 Apr 8, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kylekatarnls kylekatarnls deleted the kylekatarnls:allow-non-string-return-date-macro branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.