Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add retryAfter in Notification and Mailable object #28484

Merged

Conversation

Projects
None yet
2 participants
@arxeiss
Copy link
Contributor

commented May 10, 2019

Since PR #28265 is merged, programmer can set retryAfter in Job property or method. However this is not possible to do with Notification and Mailable class. So I added simple methods, which do this.

Basically it acts as any other job, so retryAfter() method in SendQueuedNotifications and SendQueuedMailable check existence of retryAfter property or method in notification or mail class.

I tried to find tests to modify, but it looks there aren't any. Am I correct?

@arxeiss arxeiss changed the title Add possibility to set retryAfter in Notification and Mailable object [5.8] Add retryAfter in Notification and Mailable object May 11, 2019

@taylorotwell taylorotwell merged commit 08f2555 into laravel:5.8 May 11, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arxeiss arxeiss deleted the arxeiss:retryAfterToNotificationsAndMailable branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.