[5.8] Add retryAfter in Notification and Mailable object#28484
Merged
taylorotwell merged 2 commits intoMay 11, 2019
Conversation
arxeiss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PR #28265 is merged, programmer can set
retryAfterin Job property or method. However this is not possible to do with Notification and Mailable class. So I added simple methods, which do this.Basically it acts as any other job, so
retryAfter()method inSendQueuedNotificationsandSendQueuedMailablecheck existence ofretryAfterproperty or method in notification or mail class.I tried to find tests to modify, but it looks there aren't any. Am I correct?