[5.8] Implement better email validation support#29589
Merged
Merged
Conversation
These changes allow for multiple email validators to be added when checking for valid emails. This is a continuation of the previous PR: #26503 Basically this allows for two things: - Make use of multiple email validators provided by the egulias/email-validator package - Use the previous (and much requested) filter_var validation By default nothing's breaking because it'll still use the RFC validator to when no validators are passed to the email validation rule. But you can opt to include different ones or multiple ones: 'email' => 'email:rfc,dns' Or opt for the pre-5.8 behavior: 'email' => 'email:filter' Which will use `filter_var` to validate the email address. This should give people a little more flexibility when doing email validation.
Contributor
|
@driesvints: Could we get the "reasons" as errors as well? For example the MX DNS check still just says: "The email must be a valid email address." instead of "No MX or A DSN record was found for this email". They got a bunch of errors and exceptions: https://github.com/egulias/EmailValidator/blob/master/EmailValidator/Exception/NoDNSRecord.php |
Member
Author
|
@tillkruss yeah but I won't have time to implement this myself. Feel free to send in a pr. |
Contributor
|
@driesvints: Their error messages are not that great. I made my own rule. <?php
namespace App\Rules;
use Illuminate\Contracts\Validation\Rule;
use Egulias\EmailValidator\EmailValidator;
use Egulias\EmailValidator\Validation\DNSCheckValidation;
use Egulias\EmailValidator\Validation\SpoofCheckValidation;
use Egulias\EmailValidator\Validation\NoRFCWarningsValidation;
use Egulias\EmailValidator\Validation\MultipleValidationWithAnd;
use Egulias\EmailValidator\Warning\NoDNSMXRecord;
use Egulias\EmailValidator\Exception\NoDNSRecord;
use Egulias\EmailValidator\Validation\Error\SpoofEmail;
class ValidEmail implements Rule
{
protected $validator;
public function __construct()
{
$this->validator = new EmailValidator;
}
public function passes($attribute, $value)
{
$validations = [
new NoRFCWarningsValidation,
new SpoofCheckValidation,
new DNSCheckValidation,
];
$validation = new MultipleValidationWithAnd(
$validations,
MultipleValidationWithAnd::STOP_ON_ERROR
);
return $this->validator->isValid($value, $validation);
}
public function message()
{
$error = $this->validator->getError()->getErrors()[0];
if ($error instanceof SpoofEmail) {
return 'The :attribute contains suspicious characters.';
}
if ($error instanceof NoDNSMXRecord) {
return 'The :attribute does not have a valid MX record.';
}
if ($error instanceof NoDNSRecord) {
return 'The :attribute does not have a valid DNS record.';
}
return 'The :attribute must be a valid email address.';
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow for multiple email validators to be added when checking for valid emails. This is a continuation of the previous PR: #26503
Basically this allows for two things:
By default nothing's breaking because it'll still use the RFC validator to when no validators are passed to the email validation rule. But you can opt to include different ones or multiple ones:
Or opt for the pre-5.8 behavior:
Which will use
filter_varto validate the email address. This should give people a little more flexibility when doing email validation.PS: I wasn't sure if we should return something for the
getErrorandgetWarningsmethods in theFilterEmailValidationclass. I've left them with some defaults and everything seems to be working ok.