[6.x] Sort imports alphabetically on class generation from stub #29951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpok
force-pushed
the
feature/order-imports
branch
from
0c538a5
to
358c5b3
Compare
netpok
force-pushed
the
feature/order-imports
branch
from
358c5b3
to
9dd98ba
Compare
netpok
changed the title
|
Better to update the stubs themselves, maybe? |
|
@GrahamCampbell This was required because of the "dynamic" imports which are replaced when stubs are compiled to actual classes. |
|
Is it really necessary? Since stubs, it is just a stub, and you can do the ordering in your class ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes sure that the imports are correctly sorted after generating a class from a stub.
It alphabetically sorts the first use block when it has no whitespace before it (meaning its a file level import), otherwise it does not change the output.