Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add the ability to delete a resolved log driver/channel #30132

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@morloderex
Copy link
Contributor

commented Sep 29, 2019

Backstory:

I am currently working on a little multi-tenancy project. In order for me to ease the development i did a little research and found the tenancy/tenancy origanisation was building a new package(s). Specifically tailored to my needs. It is not released yet. So I thought i might help them out with the development of it.

Motivation:

By doing some digging into their implementation of their log affect, I discovered that they are trying to delete the resolved channel/driver at runtime in order for the logging to be recreated for the same driver/channel but with different configuration keys/values.

But they currently have to recreate the entire LogManager instance as the LogManager currently does not have the ability to delete a resolved channel. I found that we have a purge method (aliased to disconnect) on the DatabaseManager. So i figured why not make it possible here as well?

This is what this pr is all about, the ability to delete a resolved log channel/driver.

@morloderex morloderex changed the title Add the ability to delete a resolved log driver/channel [6.x] Add the ability to delete a resolved log driver/channel Sep 29, 2019
@taylorotwell taylorotwell merged commit cf00422 into laravel:6.x Sep 30, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.