Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Update `artisan down` output to be consistent with `artisan up` #30422

Merged
merged 1 commit into from Oct 26, 2019

Conversation

@fitztrev
Copy link
Contributor

fitztrev commented Oct 25, 2019

This makes the output of artisan down like artisan up if there's no change in maintenance mode.

The application was already up, so this is expected behavior:

# Running `up` twice in a row (from a down state)

$ php artisan up
Application is now live.
$ php artisan up
Application is already up.

Effect of this change:

The application was already down:

# Running `down` twice in a row (from an up state)

$ php artisan down
Application is now in maintenance mode.
$ php artisan down
- Application is now in maintenance mode.
+ Application is already down.

It checks the same way the UpCommand.php checks (added via PR #28765)

@fitztrev fitztrev changed the title [6.x] Update `artisan down` output to say if app is already down [6.x] Update `artisan down` output to be consistent with `artisan up` Oct 25, 2019
@taylorotwell taylorotwell merged commit 2629b28 into laravel:6.x Oct 26, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.