[6.x] Fix method and remove duplication #30632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tweak made by taylor on the on the
FileFactory::create()
has two problems1- Using file_put_contents() on a resource this causes the following problem
ErrorException : file_put_contents() expects parameter 1 to be a valid path, resource given
2- Second one using the
$tmp
inside the closure without passing it viause()
this will cause an undefined variable error.Instead of applying fixes to these two problems i restaured the original code of the
create()
method plus checking if the$kilobytes
is a string, if so i'll just call thecreateWithContent()
instead