Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Force usage getting timestamps columns #30697

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@fheider
Copy link
Contributor

fheider commented Nov 27, 2019

laravel/ideas#1932

The trait has 2 functions getCreatedAtColumn and getUpdatedAtColumn, but dont use it exclusively.
Better would be a single point to get the right columns.

In the end, the user has the same 2 options to set the column names: via const or via getXColumn(). But now you dont need to change both, cause the constants are only used in the getXColumn-methods.

@GrahamCampbell GrahamCampbell changed the title force usage getting timestamps columns [6.x] Force usage getting timestamps columns Nov 27, 2019
@taylorotwell taylorotwell merged commit 93b5068 into laravel:6.x Nov 29, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.