Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix RedirectController parameters pop #30783

Merged
merged 1 commit into from Dec 9, 2019
Merged

Conversation

@clementmas
Copy link
Contributor

clementmas commented Dec 7, 2019

Fixes #30639

Using pop() to access parameters is not precise and can leads to bugs like the one described in the issue. So using get() is a safer approach.

@clementmas clementmas changed the title Fixes RedirectController parameters pop Fix RedirectController parameters pop Dec 7, 2019
@GrahamCampbell GrahamCampbell changed the title Fix RedirectController parameters pop [6.x] Fix RedirectController parameters pop Dec 7, 2019
@taylorotwell taylorotwell merged commit ff807cc into laravel:6.x Dec 9, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.