Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Remove duplicate output when publishing tags #31333

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@andrewnclark
Copy link
Contributor

andrewnclark commented Feb 3, 2020

Screenshot 2020-02-03 at 10 55 09

When using the vendor:publish to publish a specific tag (either via the prompt or providing a --tag option) the "Publish Complete." line was duplicated - it's output at the end of the handle method and during the publish tag method. This initially caused me some confusion as I thought the process was being duplicated.

This PR removes the output from the publishTag method and allows the handle method to output a single instance when the process is complete.

@andrewnclark andrewnclark changed the title Remvoe duplicate output when publishing tags Remove duplicate output when publishing tags Feb 3, 2020
@driesvints driesvints changed the title Remove duplicate output when publishing tags [6.x] Remove duplicate output when publishing tags Feb 3, 2020
@taylorotwell taylorotwell merged commit 862bd48 into laravel:6.x Feb 3, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.