[7.x] Fix ComponentAttributeBag merge behaviour #31932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the bug I raised in #31898. Below is an illustration of what this PR fixes.
With a component that defines some default attributes:
If the component is used like this
We would expect the rendered template to be:
But the current implementation renders:
This PR fixes the implementation of ComponentAttributeBag::merge() so that it doesn't ignore attribute values specified in the template that is calling the component.
ViewComponentAttributeBagTest
has been updated.