Skip to content

[7.x] Fix Console expectation assertion order#32258

Merged
taylorotwell merged 2 commits into
laravel:7.xfrom
nuernbergerA:fix-console-assertions-order
Apr 6, 2020
Merged

[7.x] Fix Console expectation assertion order#32258
taylorotwell merged 2 commits into
laravel:7.xfrom
nuernbergerA:fix-console-assertions-order

Conversation

@nuernbergerA

Copy link
Copy Markdown
Contributor

This PR solves the ordering bug when using command and other assertions in the same test.

Please find more detailed information in issue #32256

Current State

Laravel command assertions (expectations) are being run before the application gets destroyes.
This is why command assertions alwaysrun at the end of the test and not in the provided order inside the test.

Solution

This PR changes the implementation so that the command assertions run immediately after defining them.
Fixes #32256.

@taylorotwell
taylorotwell merged commit ee59dae into laravel:7.x Apr 6, 2020
@jasonmccreary

Copy link
Copy Markdown
Contributor

@nuernbergerA, I thought you had to chain the command setup with run or execute. Is this now different?

@nuernbergerA

nuernbergerA commented Apr 7, 2020

Copy link
Copy Markdown
Contributor Author

@jasonmccreary short answer: it should all run as before, except that failing questions fail in the expected order.

execute() is an alias for run() which is called on __destruct()

All I/O related assertions have been registered on this hook which was called here

Let's take @christophrumpel example

public function it_imports_users_to_the_database(): void
{
    //expectsQuestion() registers callback on TestCase
    $this->artisan('import:users')
            ->expectsQuestion('Please provide the URL to import users:', 'https://myapi.com/users')
            //PendingCommand calls __destruct() / run()
            ->assertExitCode(0);

    //This evaluates immediately
    $this->assertCount(100, User::all());

   //TestCase::tearDown()
   //executes previous defined callback
}

So the only change is that if an expectedQuestion() wasn't asked it failed before it evaluates assertCount()

I hope my attempt to illustrate the issue didn't confuse you.

@nuernbergerA
nuernbergerA deleted the fix-console-assertions-order branch March 19, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertions order is wrong when using command assertions combined with other ones

3 participants