[7.x] Fix Console expectation assertion order#32258
Merged
taylorotwell merged 2 commits intoApr 6, 2020
Merged
Conversation
Contributor
|
@nuernbergerA, I thought you had to chain the command setup with |
Contributor
Author
|
@jasonmccreary short answer: it should all run as before, except that failing questions fail in the expected order.
All I/O related assertions have been registered on this hook which was called here Let's take @christophrumpel example public function it_imports_users_to_the_database(): void
{
//expectsQuestion() registers callback on TestCase
$this->artisan('import:users')
->expectsQuestion('Please provide the URL to import users:', 'https://myapi.com/users')
//PendingCommand calls __destruct() / run()
->assertExitCode(0);
//This evaluates immediately
$this->assertCount(100, User::all());
//TestCase::tearDown()
//executes previous defined callback
}So the only change is that if an I hope my attempt to illustrate the issue didn't confuse you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the ordering bug when using command and other assertions in the same test.
Please find more detailed information in issue #32256
Current State
Laravel command assertions (expectations) are being run before the application gets destroyes.
This is why command assertions
alwaysrun at the end of the test and not in the provided order inside the test.Solution
This PR changes the implementation so that the command assertions run immediately after defining them.
Fixes #32256.