[7.x] Prevent usage of get*AtColumn() when model has no timestamps#33634
Merged
Conversation
GrahamCampbell
changed the title
driesvints
approved these changes
Jul 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Althought it is uncommon, people may want to be able to reuse
Eloquent\Concerntraits to build their own model implementation. In my case, I used them to build models objects from multiple sources (XML mainly), and I did not want to use theHasTimestampstrait.With the proposed modification, using the
HasAttributesstandalone will not require anymore to definegetCreatedAtColumn()andgetUpdatedAtColumn(), ifusesTimestamps()returnsfalse.I do not know if I should add a test for this as existing usages inside framework are already tested. I can produce a test for the specific usage I mentionned if you ask me.