Skip to content

[7.x] Using "public static property" in View Component causes an error #34058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

[7.x] Using "public static property" in View Component causes an error #34058

merged 1 commit into from
Aug 31, 2020

Conversation

kozo
Copy link
Contributor

@kozo kozo commented Aug 29, 2020

Currently "View Component" cannot use "public static property".
This PR fixes it, with tests.

error details:

Accessing static property Illuminate\Tests\View\TestSampleViewComponent::$publicStaticCounter as non static

Thx.😄

@taylorotwell taylorotwell merged commit f07657a into laravel:7.x Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozo @taylorotwell