[8.x] fix SQL Server command generation #35317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @rodrigopedra 👍 |
|
You're welcome! @paras-malhotra Thank you for the nice addition, very handy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
php artisan dbcommand introduced in PR #35304 adds a very nice feature that allows the developer to easily connect to the DBMS CLI using the connection parameters already configured in the application.But as noted by that PR author, he didn't have SQL Server available, then he couldn't test the generated command against it.
I tested locally the new command and the command-line generated by the original PR fails when executed. This PR fixes the command for SQL Server.
Sample command generated before this PR:
Note command options and their values are quoted together.
Sample command generated after this PR: