Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running schedule:test on CallbackEvent #38146

Merged
merged 1 commit into from Jul 27, 2021

Conversation

olivernybroe
Copy link
Contributor

When running the schedule:test on a scheduler added with CallbackEvent

$schedule->call(MyScheduleClass::class . '@__invoke')->everyTenMinutes()

It shows up the following way in the schedule command.
image
However choosing one of the values results in the following
image

To fix I added a fallback to getSummaryForDisplay if no command property.

Which makes them show up the following way
image
And I can now actually run them 馃憤

A better solution could possibly be to add a new method which is responsible for generating the name for this, so it wouldn't need a fallback like this, however not sure if it is needed.

@taylorotwell taylorotwell merged commit 97beb00 into laravel:8.x Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants